Cleanup additional resources during uninstall #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoletaPopoviciu
requested review from
a team,
kschoche and
ishustava
and removed request for
a team
kschoche
reviewed
Oct 29, 2021
kschoche
reviewed
Oct 29, 2021
kschoche
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Most excellent work!!
I had one additional thought, and we don't usually require negative testing, but given this is deleting things would it make sense to add a test where we pass in a different release or namespace to ensure that our code is not actually deleting other people's stuff? If that doesnt make sense I'd be happy to explain :)
Co-authored-by: Kyle Schochenmaier <kschoche@gmail.com>
|
Resolved the CHANGELOG conflict, should we go ahead and merge @NicoletaPopoviciu |
ishustava
approved these changes
Nov 5, 2021
kschoche
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: