Prevent using reserved names for ns's/partitions #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some names are reserved by Consul and can't be used for namespaces or partitions. Catching this early before the helm install is a better UX than having the install fail (in the case of partitions) or succeed (in the case of namespaces) and then fail during syncing or injection.
lkysow
commented
Nov 5, 2021
| {{- if or (eq "system" $name) (eq "universal" $name) (eq "consul" $name) (eq "operator" $name) (eq "root" $name) }} | ||
| {{- fail (cat "The name" $name "set for key" $key "is reserved by Consul for future use." ) }} | ||
| {{- end }} | ||
| {{- end -}} |
There was a problem hiding this comment.
Review notes:
- See template docs for how it works
- I'm using
catinsidefailto get those values interpolated into the error string.
lkysow
requested review from
a team,
ishustava and
thisisnotashwin
and removed request for
a team
ishustava
approved these changes
Nov 5, 2021
| {{- if or (eq "system" $name) (eq "universal" $name) (eq "consul" $name) (eq "operator" $name) (eq "root" $name) }} | ||
| {{- fail (cat "The name" $name "set for key" $key "is reserved by Consul for future use." ) }} | ||
| {{- end }} | ||
| {{- end -}} |
thisisnotashwin
approved these changes
Nov 8, 2021
Comment on lines
+1542
to
+1552
| cd `chart_dir` | ||
| local -r name="$1" | ||
| run helm template \ | ||
| -s templates/connect-inject-deployment.yaml \ | ||
| --set 'connectInject.enabled=true' \ | ||
| --set "connectInject.consulNamespaces.consulDestinationNamespace=$name" . | ||
|
|
||
| [ "$status" -eq 1 ] | ||
| [[ "$output" =~ "The name $name set for key connectInject.consulNamespaces.consulDestinationNamespace is reserved by Consul for future use" ]] | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some names are reserved by Consul and can't be used for namespaces or
partitions. Catching this early before the helm install is a better UX
than having the install fail (in the case of partitions) or succeed (in
the case of namespaces) and then fail during syncing or injection.
This code uses some tricks:
Fixes #593
Checklist: