Rename to exported services #902
Merged
+379
−1,487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
force-pushed
the
rename-to-exported-services
branch
6 times, most recently
from
3f7c5eb
to
c90e830
Compare
thisisnotashwin
commented
Dec 7, 2021
.circleci/config.yml
Outdated
| @@ -70,7 +70,7 @@ commands: | |||
| type: string | |||
| consul-k8s-image: | |||
| type: string | |||
| default: "docker.mirror.hashicorp.services/hashicorpdev/consul-k8s-control-plane:latest" | |||
| default: "ashwinvenkatesh/consul-k8s@sha256:ca2bde89a28563d40100039c217df6f750cc8b3bd72b31036bb1aaaff74f23fc" | |||
There was a problem hiding this comment.
remove this before merging to master.
thisisnotashwin
requested review from
a team,
ndhanushkodi and
t-eckert
and removed request for
a team
thisisnotashwin
requested review from
lkysow
and removed request for
ndhanushkodi
t-eckert
reviewed
Dec 7, 2021
thisisnotashwin
force-pushed
the
rename-to-exported-services
branch
from
1c0de55
to
c7782a8
Compare
lkysow
approved these changes
Dec 7, 2021
- Update anonymous token job to not run in non-default partitions. The current implementation breaks against the latest consul version.
thisisnotashwin
force-pushed
the
rename-to-exported-services
branch
from
c7782a8
to
b45f341
Compare
thisisnotashwin
force-pushed
the
rename-to-exported-services
branch
from
b45f341
to
ed81558
Compare
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
AdminPartitionstoPartitionswhere necessary.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: