Add new value ui.dashboardURLTemplates #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hashicorp/consul-helm#1006 is an issue where this caused problems. |
lkysow
requested review from
a team and
ishustava
and removed request for
a team
ishustava
approved these changes
Jan 14, 2022
This value is used to set Consul's `ui_config.dashboard_url_templates`
config. I'm pulling it out as its own value rather than getting users
to just use `server.extraConfig` because these template strings always
use the characters `{{` and when used within `server.extraConfig`,
users need to escape those characters.
Before:
```yaml
server:
extraConfig: |
{
"ui_config": {
"dashboard_url_templates": {
"service": "http://grafana/service/{{ "{{" }}Service.Name}}"
}
}
}
```
Now:
```yaml
ui:
dashboardURLTemplates:
service: "http://grafana/service/{{Service.Name}}"
```
lkysow
force-pushed
the
lkysow/dashboard-url-templates
branch
from
35ef418
to
7382b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value is used to set Consul's
ui_config.dashboard_url_templatesconfig. I'm pulling it out as its own value rather than getting users
to just use
server.extraConfigbecause these template strings alwaysuse the characters
{{and when used withinserver.extraConfig,users need to escape those characters.
Before:
Now:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: