Add - separated names for config entry crds #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
requested review from
a team,
kschoche and
thisisnotashwin
and removed request for
a team
| @@ -29,6 +29,7 @@ func init() { | |||
| // +kubebuilder:printcolumn:name="Synced",type="string",JSONPath=".status.conditions[?(@.type==\"Synced\")].status",description="The sync status of the resource with Consul" | |||
| // +kubebuilder:printcolumn:name="Last Synced",type="date",JSONPath=".status.lastSyncedTime",description="The last successful synced time of the resource with Consul" | |||
| // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="The age of the resource" | |||
| // +kubebuilder:resource:shortName="exported-services" | |||
There was a problem hiding this comment.
it's funny that it is the "short" name even though it is a character longer.
There was a problem hiding this comment.
😂 I know I'm stretching the recommended usage... but they don't have an aliases field!
kschoche
approved these changes
Jan 14, 2022
Right... no I just forgot them! |
thisisnotashwin
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Love the "short" names ;)
Great job @lkysow !! Hitting approve assuming the CRDs will be migrated into the helm charts too!!!
For example allow both kubectl get ingressgateways and kubectl get ingress-gateways. When specified in .hcl or .json the config entries are dash-separated so this makes it consistent if someone uses a dash by mistake after reading our docs.
lkysow
force-pushed
the
lkysow/short-names
branch
from
5e8890e
to
6af8bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example allow both kubectl get ingressgateways and
kubectl get ingress-gateways.
When specified in .hcl or .json the config entries are dash-separated so
this makes it consistent if someone uses a dash by mistake after reading
our docs.
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: