ui: Ensure role remove button styling is correct #11297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). consul – ./website🔍 Inspect: https://vercel.com/hashicorp/consul/6fioESDLkV2rKogm5VXKG7h3LnXz [Deployment for 312a6c9 failed] consul-ui-staging – ./ui🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/EwdejGPpiHaT5uQpfkFVMBfZwXSZ [Deployment for 312a6c9 failed] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @vinayak03's work in #11260 I spotted a little visual issue in the Token Form > Role Listing confirmation dialog.
This PR rather horribly fixes it up by cheating and using the
tabindexto target certain buttons, which usually would be an absolute no-no (I know we only set thetabindexon these specific buttons)The reason why I was ok doing this here is that we have a much stronger code now around these menus in 1.9 forwards (still a work in progress but stronger) and the issue is fixable in 1.9 forwards without using a 'no-no'. FYI: slightly different issue still exists in 1.9 forwards but the fix there is not as ... umm ... bad.
All in all, this fix is the easy/pragmatic way to do this considering the fix stays on 1.8 and no further, and 1.8 will soon be dropped from our support anyway. This may be the last amend we make to 1.8.
Lastly, different PR against
maincoming which will be backported to 1.9/1.10/1.11 only.Before:
After: