Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Improve ux around ACL token to help users avoid overwriting node/service identities into release/1.15.x #16541

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16506 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

Follow up to #16288
TLDR: node-identity and service-identity flags when specified without the merge-* flags overwrites service identities and node identities of a token. This is ambiguous to the user because we have a no-merge flag which seems to imply that on update we are merging. So we have been doing work to improve the ux by renaming/adding/sunsetting flags and adding more docs to help reduce the ambiguity

  • Marking merge-node-identities and merge-service-identities for deprecation and encouraging the use of their replacement append-node-policy and append-service-identity
  • Updating docs to clarify that using -rules overwrites existing rules
  • Adding docs for the new flags: append-node-policy and append-service-identity

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner March 6, 2023 15:01
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-1723/role-update/personally-full-quail branch from a3aac81 to 41ba8e8 Compare March 6, 2023 15:01
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-1723/role-update/personally-full-quail branch from bbf2bfc to b68737d Compare March 6, 2023 15:01
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified labels Mar 6, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit 583466b into release/1.15.x Mar 6, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/NET-1723/role-update/personally-full-quail branch March 6, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants