Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixup note about node scope for admin partitions #17147

Merged
merged 1 commit into from
Apr 26, 2023
Merged

docs: fixup note about node scope for admin partitions #17147

merged 1 commit into from
Apr 26, 2023

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented Apr 26, 2023 •
edited
Loading

Description

Fixup an inaccurate note about nodes being scoped to namespaces.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@mikemorris mikemorris requested a review from a team as a code owner April 26, 2023 16:45
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Apr 26, 2023
david-yu
david-yu approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to be back ported all the way to at least 1.13.x (current latest maintained version of Consul)

@david-yu david-yu added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test labels Apr 26, 2023
@mikemorris mikemorris added backport/1.12 backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels Apr 26, 2023
@mikemorris mikemorris merged commit f93bb65 into main Apr 26, 2023
@mikemorris mikemorris deleted the docs/admin-partitions-node-scope branch April 26, 2023 17:46
This was referenced Apr 26, 2023
Closed
Closed
Merged
@jkirschner-hashicorp
Copy link
Contributor

Sometimes, the effort to backport isn't worth it for certain docs changes. A lot of our docs have been significantly changed (or even renaming / moved / broken up) between main and the last few releases. It's worth attempting the auto-backport, but fixing up others manually is a judgment call. (I'd personally say this one isn't worth manually backporting.)

@david-yu
Copy link
Contributor

Yea at least 1.15.x should have this, I think this is another instance of the backport assistant failing for certain branches.

@mikemorris mikemorris added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. and removed backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels Apr 26, 2023
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Apr 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

Assignees
No one assigned
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemorris @jkirschner-hashicorp @david-yu