New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for OPTIONS request on KVSEndpoint #1807

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@marconi

marconi commented Mar 8, 2016

For CORS this means that preflight request should now return 200 instead of 405.

@siddharthist

This comment has been minimized.

Contributor

siddharthist commented Apr 16, 2016

I would love to see this support added, is there anything I can do to help?

@jippi

This comment has been minimized.

Contributor

jippi commented Apr 16, 2016

👍

@slackpad

This comment has been minimized.

Contributor

slackpad commented Nov 17, 2016

Will take a look at this and possibly doing this at a higher level to support other endpoints.

@slackpad slackpad added this to the 0.7.4 milestone Nov 17, 2016

@Yanovskiy

This comment has been minimized.

Yanovskiy commented Mar 24, 2017

So, what about of this PR?

@slackpad slackpad removed this from the Triaged milestone Apr 18, 2017

@sethvargo

This comment has been minimized.

Contributor

sethvargo commented May 1, 2017

Hey there,

Sorry this PR sat for so long. Consul has supported http_api_response_headers for awhile which allow you to define domains for CORS requests. I'm not super familiar with CORS, but I don't think Consul's goal is to support the full specification. I'm also hesitant to add this to a single endpoint and think that, if we do add this, it needs to be done at a higher level. As such, I'm going to close this PR for now.

@sethvargo sethvargo closed this May 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment