Adds ability to deregister a service based on critical check state longer than a timeout. #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
force-pushed
the
f-deregister-critical
branch
from
30b02f3
to
aacf418
Compare
This was referenced Aug 16, 2016
slackpad
force-pushed
the
f-deregister-critical
branch
from
aacf418
to
e816274
Compare
…nger than a timeout.
slackpad
force-pushed
the
f-deregister-critical
branch
from
e816274
to
4a3d7db
Compare
| // reapServices is a long running goroutine that looks for checks that have been | ||
| // critical too long and dregisters their associated services. | ||
| func (a *Agent) reapServices() { | ||
| reap := func() { |
There was a problem hiding this comment.
I would just move this out to a named function
|
@sroskelley we'll need to keep an eye on when this drops, as it'll alleviate some of the problems we went over today :) Great work all! |
This was referenced Sep 30, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1432 and #1433, this adds a new
deregister_critical_service_afterfield to a health check definition (all check types are supported) which causes the service associated with that check to get deregistered if the check is critical for longer than the timeout.Closes #679.