Fix service syncing churn in 1.2.3/1.2.4 #5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
banks
approved these changes
Dec 20, 2018
|
Oh I missed the We currently don't backport small fixes like this since there is a lot of overhead in publishing and testing many versions - the backport branches only exist for high-impact security fixes currently. I'm going to revert the merge and merge to master instead. Next year we have plans to come up with a more coherent policy on long-term support for older version branches but for now we have no plans to cut backports to 1.2.x and 1.3.x on a regular basis so this would just get lost. |
banks
added a commit
that referenced
this pull request
Dec 20, 2018
|
Ran out of time to create new PR on master for this but I will do it later! Thanks again @42wim |
banks
added a commit
that referenced
this pull request
Jan 8, 2019
…urn (#5126) * Add default weights when adding a service with no weights to local state to prevent constant AE re-sync. This fix was contributed by @42wim in #5096 but was merged against the wrong base. This adds it to master and adds a test to cover the behaviour. * Fix tests that broke due to comparing internal state which now has default weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since upgrading from 1.2.2 to 1.2.4 a few days ago I'm getting
Synced servicemessages every ~2 minutes (and a higher load on the cluster).Found the culprit to be #4468 introduced in 1.2.3 which does not set a default weights value when registering the service, causing the service comparison to fail and keeps syncing the service.
PR against backport/1.2.x