Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Adds ability to search by policy, role or service ident names #5811

Merged
merged 6 commits into from
Jun 5, 2019

Conversation

johncowen
Copy link
Contributor

This PR adds the ability to search by Role or ServiceIdentity name to the Token listings page, and the ability to search by Policy or ServiceIdentity name to the Role listings page.

(You could already search by policies on the token listing page)

This functionality will potentially be replaced by a new search UI in the future, which will make this far nicer for users to use.

@johncowen johncowen added the theme/ui Anything related to the UI label May 8, 2019
@johncowen johncowen requested a review from a team May 8, 2019 12:39
@johncowen johncowen added this to the 1.5.0 milestone May 8, 2019
@pearkes pearkes removed this from the 1.5.0 milestone May 8, 2019
Copy link

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be new acceptance tests for these?

@johncowen
Copy link
Contributor Author

Hey @DingoEatingFuzz

Thanks for taking a look!

I added a ton of new unit and acceptance tests around this. Originally we were trying to get the feature shipped in 1.5, hence we skipped these to revisit after release as at the time as we were fairly confident this feature was good. I may have gone a bit overboard with tests here, but definitely worthwhile getting some incase we regress anywhere.

There are a few other PRs that made it but I skipped tests with as the confidence was reasonably high and we wanted to ship the feature, so hopefully you'll see a few other test heavy PRs coming for regressions sake before we move forwards with other things.

Thanks,

John

@johncowen johncowen merged commit 685b89b into master Jun 5, 2019
@johncowen johncowen deleted the feature/ui-search-roles-si branch June 5, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants