Chunking support #6172
Merged
Chunking support #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the go-raft-middleware library to allow for chunked commits. Pushing this up as PoC for the moment, it's missing various things: * Config flag to enable whether this support is turned on or not (and as a result for now any code checking sizes is just commented out) * Tests that check for too-big values are commented out (but should be reenabled once there's a config flag) * There are not yet any tests to validate that this _works properly_. It's been tested using Vault as a client but only against a single node so far which doesn't really ensure that behavior is correct. This is mostly because I'm not sure of the best way to test against a cluster, so with some input from the Consul team this shouldn't be too hard to test. However, there _are_ tests within the middleware library against Raft that sends large values concurrently and verifies the FSM after so it's possible that there isn't all that much needed at the Consul layer.
banks
requested changes
Jul 23, 2019
banks
requested changes
Jul 23, 2019
|
A note: #6206 is a PR into this PR that should implement snapshotting support with a full compliment of tests. As the majority of the code here is related to config I decided to just keep them separate for ease of reviewing the other part. |
* Add snapshot support for the chunking FSM * Add some logic to snapshot save/restore * Add chunking lifecycle test * Bump go-raftchunking * Ensure that Apply never returns nil and use a nil return to know for sure whether or not a chunked apply was interrupted via a term change. * Add a requested comment
|
Note #6206 is now merged into this PR so it can be reviewed as one. |
banks
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the go-raftchunking library to allow for chunked values.
A config flag (not exposed through CLI for the moment) allows setting the desired max value size. If a submitted value is above raft's suggested threshold it automatically does a chunking apply.
Tests checking for too-big values are now split into too-big and allowed-with-config.
Tests for the validity of the actual middleware are in the middleware's package.