Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow forwarding of some status RPCs #6198

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Allow forwarding of some status RPCs #6198

merged 3 commits into from
Jul 25, 2019

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Jul 23, 2019

The v1/status/leader and v1/status/peers can now be supplied with a dc=<datacenter query param to control getting the leader/peers for a different datacenter.

@mkeeler mkeeler added this to the 1.5.3 milestone Jul 23, 2019
@mkeeler mkeeler requested a review from a team July 23, 2019 14:52
kyhavlov
kyhavlov reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@kyhavlov kyhavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, just one question about version compatibility.

agent/consul/status_endpoint.go Show resolved Hide resolved
banks
banks approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is fine but would be awesome to have a test to cover the back-compat issue with arg encoding Kyle pointed out.

agent/consul/status_endpoint.go Show resolved Hide resolved
@mkeeler mkeeler merged commit 8b54307 into master Jul 25, 2019
@mkeeler mkeeler deleted the forward-status-leader-rpc branch July 25, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyhavlov kyhavlov kyhavlov left review comments

@banks banks banks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mkeeler @banks @kyhavlov