Add option to set TLS options in-memory for API client #7093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consul has a thing to update the vendor folder: |
hanshasselberg
added
the
waiting-reply
michelvocks
force-pushed
the
add_inmemory_certificate_api
branch
from
ed1e3c2
to
9b239b2
Compare
stale
bot
removed
the
waiting-reply
hanshasselberg
requested changes
Jan 22, 2020
hanshasselberg
added
the
waiting-reply
|
@i0rek The failing tests seem to be unrelated to the PR changes. Let me know if you need anything else. |
ghost
removed
waiting-reply
hanshasselberg
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Looks great, thank you for your help @michelvocks! The test failure is already fixed on master: #7108 I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to set in-memory certificates to the API client instead of requiring the certificate to be stored on disk in a file.
This allows us to define API client TLS options per Consul secret backend in Vault.
Related issue hashicorp/vault#4800
Note: My
go mod vendorproduced a few more deletes than expected. Happy to revoke these if necessary.