Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new golang version 1.12.16 #7153

Merged
merged 2 commits into from
Feb 3, 2020
Merged

new golang version 1.12.16 #7153

merged 2 commits into from
Feb 3, 2020

Conversation

hanshasselberg
Copy link
Member

No description provided.

@mkcp
Copy link
Contributor

mkcp commented Jan 28, 2020

Not sure we can merge this just yet -- CI is showing that the new version of Go isn't vendored on CircleCI's side. Are there specific features we want out of 1.12.16 that would warrant a workaround, or should we just keep an eye out for when this is available in Circle?

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need either a workaround (source go from not the circleCI image, or wait until a new image is available. (Is there an update stream from circle that we can watch to see when 1.12.16 would be built?)

@rboyer
Copy link
Member

rboyer commented Jan 28, 2020

You'll also need to update scripts in build-support, as well as i think the consul-releases project FYI:

$ git grep "1\.12\.13"
.circleci/config.yml:    go: &GOLANG_IMAGE circleci/golang:1.12.13
CHANGELOG.md:* Updated to compile with Go 1.12.13 which includes a fix for CVE-2019-17596 in [[Go 1.12.11](https://groups.google.com/forum/#!msg/golang-announce/lVEm7llp0w0/VbafyRkgCgAJ)] [[GH-6319](https://github.com/hashicorp/consul/pull/6759)]
build-support/docker/Build-Go.dockerfile:ARG GOLANG_VERSION=1.12.13
build-support/docker/Test-Flake.dockerfile:ENV GOLANG_VERSION 1.12.13

@hanshasselberg hanshasselberg changed the title new golang version new golang version 1.12.16 Feb 3, 2020
@hanshasselberg
Copy link
Member Author

consul-releases PR: https://github.com/hashicorp/consul-releases/pull/26

@hanshasselberg
Copy link
Member Author

@mkcp mostly because it has security fixes for windows: https://groups.google.com/forum/m/#!topic/golang-announce/Hsw4mHYc470.

@hanshasselberg hanshasselberg requested a review from a team February 3, 2020 10:49
@hanshasselberg
Copy link
Member Author

CircleCI image has arrived! 🎉

@hanshasselberg hanshasselberg self-assigned this Feb 3, 2020
@hanshasselberg hanshasselberg added the waiting-reply Waiting on response from Original Poster or another individual in the thread label Feb 3, 2020
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanshasselberg hanshasselberg merged commit fe49ea4 into master Feb 3, 2020
@hanshasselberg hanshasselberg deleted the golang-version-1.12.16 branch February 3, 2020 17:20
@hanshasselberg hanshasselberg removed the waiting-reply Waiting on response from Original Poster or another individual in the thread label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants