Take Prometheus MIME-type header into account #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
force-pushed
the
prometheus_mime_type
branch
from
afc8073
to
d5a7e59
Compare
|
damned unstable tests |
This will avoid adding format=prometheus in request and to parse more easily metrics using Prometheus. This commit follows hashicorp#6514 as the PR has been closed and extends it by accepting old Prometheus mime-type.
pierresouchay
force-pushed
the
prometheus_mime_type
branch
from
d5a7e59
to
c80b956
Compare
There was a problem hiding this comment.
Thank you for your work! Just found the PR from vault: hashicorp/vault#7958. Your solution is a little different from that. Is there a reason for that?
hanshasselberg
added
the
waiting-reply
Fixed typo to true Co-Authored-By: Hans Hasselberg <me@hans.io>
|
@i0rek Yes, I do support old mime-type of Prometheus (before standardization of openmetrics) |
ghost
removed
waiting-reply
hanshasselberg
approved these changes
Mar 3, 2020
freddygv
pushed a commit
that referenced
this pull request
Mar 12, 2020
This will avoid adding format=prometheus in request and to parse more easily metrics using Prometheus. This commit follows #6514 as the PR has been closed and extends it by accepting old Prometheus mime-type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid adding format=prometheus in request and to parse more easily metrics using Prometheus.
This commit follows #6514 and extends it by accepting old Prometheus mime-type.