ui: Redesign - Service Detail Page #7655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
force-pushed
the
ui/feature/redesign-service-detail-page
branch
2 times, most recently
from
1b94371
to
9eaafc8
Compare
johncowen
reviewed
Apr 17, 2020
johncowen
reviewed
Apr 17, 2020
There was a problem hiding this comment.
Hey hey!
Ok so looks like I said a lot here, don't let this fool you! I think the majority of the work here is all good, just a couple of nips and tucks, and I left a few comments for future work also.
Lemme know what you think, or we can catch up when you are around.
kaxcode
force-pushed
the
ui/feature/redesign-service-detail-page
branch
2 times, most recently
from
ed90a78
to
eeff0d8
Compare
kaxcode
force-pushed
the
ui/feature/redesign-service-detail-page
branch
from
eeff0d8
to
1cdc37b
Compare
johncowen
reviewed
Apr 21, 2020
There was a problem hiding this comment.
I left more notes for chatting through on things that aren't super important, so we can almost get this merged I think. I think the most important thing here before we do that is the null > model comment though.
P.S. Just noticed that I added some additional comments to some previously resolved convo's but github doesn't 'unresolve' them, not sure how I can do this, so be sure to open those convo's up down below here.
* Implement ConsulServiceInstanceList to Service Detail page * Implement ConsulExternalSource to Services Show page header * Update services/show page object
kaxcode
force-pushed
the
ui/feature/redesign-service-detail-page
branch
from
1cdc37b
to
153a61f
Compare
johncowen
approved these changes
Apr 21, 2020
johncowen
pushed a commit
that referenced
this pull request
Apr 30, 2020
* Create ConsulServiceInstanceList with styling and test * Implement ConsulServiceInstanceList to Service Detail page * Implement ConsulExternalSource to Services Show page header * Update services/show page object * Update the styling of CompositeRow * Refactor ConsulServiceList component and styling * Update ConsulExternalSource to say 'Registered via...' * Upgrade consul-api-double to patch 2.14.1 * Fix up tests to not use Kind in service models * Update ListCollection with clickFirstAnchor action * Add $typo-size-450 to typography base variables
kaxcode
added a commit
that referenced
this pull request
May 11, 2020
* Create ConsulServiceInstanceList with styling and test * Implement ConsulServiceInstanceList to Service Detail page * Implement ConsulExternalSource to Services Show page header * Update services/show page object * Update the styling of CompositeRow * Refactor ConsulServiceList component and styling * Update ConsulExternalSource to say 'Registered via...' * Upgrade consul-api-double to patch 2.14.1 * Fix up tests to not use Kind in service models * Update ListCollection with clickFirstAnchor action * Add $typo-size-450 to typography base variables
johncowen
pushed a commit
that referenced
this pull request
May 12, 2020
* Create ConsulServiceInstanceList with styling and test * Implement ConsulServiceInstanceList to Service Detail page * Implement ConsulExternalSource to Services Show page header * Update services/show page object * Update the styling of CompositeRow * Refactor ConsulServiceList component and styling * Update ConsulExternalSource to say 'Registered via...' * Upgrade consul-api-double to patch 2.14.1 * Fix up tests to not use Kind in service models * Update ListCollection with clickFirstAnchor action * Add $typo-size-450 to typography base variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Link