-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve ModifyIndex for unchanged entry in KVS TXN #7832
Conversation
Hi @a-zagaevskiy, can you please add a test to It would be based on this following test, but would run multiple KVSet operations instead of running every possible operation once: consul/agent/consul/state/txn_test.go Line 510 in 57096f8
|
Hi @freddygv ! Is it okay? To be honest, I'm not sure that I chose an appropriate name for the test. And there are some doubts about how I've set up that commits. But I would be glad for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I made one other minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the issue and fix in a PR @a-zagaevskiy. This is good to merge now!
Glad I could help a little! And what about the corresponding issue? Should I close it manually right now? It looks like I didn't link it properly with this PR. |
Ah yep. In order to auto-close issues the PR description needs contain: I just closed the issue though. Thanks for the reminder. |
These changes are made to preserve ModifyIndex for entries that are left untouched in the KVStore during a transaction.