Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: ConsulKind explanatory tooltip panels #8048

Merged
merged 8 commits into from
Jun 9, 2020

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jun 8, 2020

panels

This PR adds 'tooltip panels' to the ConsulKind icon/pill showing explanatory text and links for documentation on each gateway.

Few things to explain here from a code perspective:

  1. I went for keeping the text/copy inside the template.
  2. I'm using a new from-entries helper here, but I would have rather used ember-composable-helpers version of this. Unfortunately performing an upgrade here gave dependency problems, which would have meant having to upgrade other packages, something I'd rather not do this close to a release. Post release I'd like to switch our from-entries out and use the one provided by ember-composable helpers, following a complete upgrade of all of our packages.
  3. Ideally all of this could use popper.js now that we are using something based on that, something for the future.
  4. I pulled the info icon work out of the menupanel as it is only being used in the namespace menu right now, I made that specific to the namespace menu only.
  • Final links still need adding here.

@johncowen johncowen added the theme/ui Anything related to the UI label Jun 8, 2020
@johncowen johncowen requested a review from a team June 8, 2020 11:34
@johncowen
Copy link
Contributor Author

Screenshot 2020-06-08 at 17 40 19

@kaxcode I left it at this in the end, a tiny bit better spacing there ^

@kaxcode kaxcode self-requested a review June 8, 2020 17:09
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@johncowen johncowen added this to the 1.8.0 milestone Jun 9, 2020
@johncowen johncowen merged commit aafbfa1 into ui-staging Jun 9, 2020
@johncowen johncowen deleted the ui/feature/tooltip-panel branch June 9, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants