Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the agentpb package #8362

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Refactor the agentpb package #8362

merged 1 commit into from
Jul 23, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Jul 22, 2020

First move the whole thing to the top-level proto package name.

Secondly change some things around internally to have sub-packages.

@mkeeler mkeeler requested a review from a team July 22, 2020 18:34
Base automatically changed from dep/mapstructure to master July 22, 2020 19:13
dnephin
dnephin approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agent/auto-config/auto_config_test.go Outdated Show resolved Hide resolved
@mkeeler mkeeler force-pushed the refactor/protobuf branch 5 times, most recently from 6b86435 to aa3709b Compare July 23, 2020 14:33
@mkeeler
Refactor the agentpb package
19170b8 
First move the whole thing to the top-level proto package name.

Secondly change some things around internally to have sub-packages.
@mkeeler mkeeler merged commit 2713c0e into master Jul 23, 2020
@mkeeler mkeeler deleted the refactor/protobuf branch July 23, 2020 15:24
@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit 2713c0e onto release/1.8.x failed! Build Log

mkeeler added a commit that referenced this pull request Jul 23, 2020
@mkeeler
Refactor the agentpb package (#8362)
3228cf9 
First move the whole thing to the top-level proto package name.

Secondly change some things around internally to have sub-packages.
# Conflicts:
#	agent/consul/state/acl.go
#	agent/consul/state/acl_test.go
@mkeeler
Copy link
Member Author

mkeeler commented Jul 23, 2020

Backport PR is #8366

mkeeler added a commit that referenced this pull request Jul 23, 2020
@mkeeler
Backport: #8362 (#8366)
56b4643 
Refactoring of the agentpb package.

First move the whole thing to the top-level proto package name.

Secondly change some things around internally to have sub-packages.
# Conflicts:
#	agent/consul/state/acl.go
#	agent/consul/state/acl_test.go
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer left review comments

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkeeler @hashicorp-ci @rboyer @dnephin