Move generation of CA Configuration into a method on the RuntimeConfig
#8363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddygv
reviewed
Jul 22, 2020
mkeeler
force-pushed
the
refactor/ca-config-gen
branch
from
995b409
to
24e19d9
Compare
mkeeler
force-pushed
the
refactor/protobuf
branch
2 times, most recently
from
48d6d6d
to
6d5e062
Compare
|
Should the commit from |
mkeeler
force-pushed
the
refactor/ca-config-gen
branch
from
24e19d9
to
5c8a3cd
Compare
mkeeler
force-pushed
the
refactor/ca-config-gen
branch
from
5c8a3cd
to
fd26fa9
Compare
mkeeler
force-pushed
the
refactor/protobuf
branch
4 times, most recently
from
6b86435
to
aa3709b
Compare
mkeeler
force-pushed
the
refactor/ca-config-gen
branch
from
fd26fa9
to
8ab1fed
Compare
mkeeler
force-pushed
the
refactor/protobuf
branch
from
aa3709b
to
19170b8
Compare
…thod on the RuntimeConfig This allows this to be reused elsewhere.
mkeeler
force-pushed
the
refactor/ca-config-gen
branch
from
8ab1fed
to
0550445
Compare
|
🍒✅ Cherry pick of commit 2ee9fe0 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jul 23, 2020
…thod on the RuntimeConfig (#8363) This allows this to be reused elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was done in the
Agent.consulConfigfunction but we will need this in other places for Agent Auto Configuration so this functionality is being moved to a method on theRuntimeConfig