Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require token replication to be enabled in secondary dcs when ACLs are enabled with AutoConfig #8451

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Aug 6, 2020

AutoConfig will generate local tokens for clients and the ability to use local tokens is gated off of token replication being enabled and being configured with a replication token. Therefore we already have a hard requirement on having token replication enabled, this commit just makes sure to surface that to the operator instead of having to discern what the issue is from RPC errors.

…e enabled with AutoConfig

AutoConfig will generate local tokens for clients and the ability to use local tokens is gated off of token replication being enabled and being configured with a replication token. Therefore we already have a hard requirement on having token replication enabled, this commit just makes sure to surface that to the operator instead of having to discern what the issue is from RPC errors.
@mkeeler mkeeler requested a review from a team August 6, 2020 18:58
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agent/config/builder.go Outdated Show resolved Hide resolved
agent/config/runtime_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@crhino crhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkeeler mkeeler merged commit 67dec3b into master Aug 7, 2020
@mkeeler mkeeler deleted the feature/auto-config/require-token-replication branch August 7, 2020 14:20
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 67dec3b onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Aug 7, 2020
…e enabled with AutoConfig (#8451)

AutoConfig will generate local tokens for clients and the ability to use local tokens is gated off of token replication being enabled and being configured with a replication token. Therefore we already have a hard requirement on having token replication enabled, this commit just makes sure to surface that to the operator instead of having to discern what the issue is from RPC errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants