fsm: Fix snapshot bug with restoring node/service/check indexes #8474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyhavlov
force-pushed
the
snapshot-index-fix
branch
from
8bcddc4
to
a35594b
Compare
freddygv
reviewed
Aug 11, 2020
kyhavlov
force-pushed
the
snapshot-index-fix
branch
from
a35594b
to
c39a275
Compare
freddygv
approved these changes
Aug 11, 2020
This was referenced Aug 11, 2020
This was referenced Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where nodes, services, and checks would not be restored with the correct Create/ModifyIndex when restoring from a snapshot. The KV entries didn't have this issue because we do a raw tx.Insert of the entry that we read from the transaction (so it includes the Create/ModifyIndex), but when loading in catalog objects we have to do additional bookkeeping, so we weren't doing a raw insert there. This PR adds a
preserveIndexargument to some of the internal state store functions to enable keeping the index we read from the snapshot, without allowing users to arbitrarily modify these fields during a normal update.Fixes #8377.