[bugfix] Prometheus metrics without warnings #9510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
force-pushed
the
prometheus_metrics_help_duplicate_fix
branch
2 times, most recently
from
eb84f5e
to
8655951
Compare
go-metrics is updated to 0.3.6 to properly handle help in prometheus metrics This fixes hashicorp#9303 and hashicorp#9471
pierresouchay
force-pushed
the
prometheus_metrics_help_duplicate_fix
branch
from
8655951
to
408b249
Compare
|
damned unstable tests:
|
|
@mkcp Here is the fix with the patch hashicorp/go-metrics#122 included |
mkcp
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Excellent - appreciate you making a changelog note as well. Thanks again @pierresouchay !
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/305409. |
|
🍒✅ Cherry pick of commit f0b7864 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jan 6, 2021
…uplicate_fix [bugfix] Prometheus metrics without warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-metrics is updated to 0.3.6 to properly handle help in prometheus metrics
This fixes #9303