Backport to release/1.8.x: #9738 - Stop background refresh of cached data for requests that result in ACL not found errors #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). consul – ./website🔍 Inspect: https://vercel.com/hashicorp/consul/nmzmax5jg consul-ui-staging – ./ui🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/51oz4d344 |
dnephin
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is the backport of #9738 which required resolving some conflicts with changes to how the cache is structured. In 1.9.x the expiry heap implementation was moved out of the cache package and into lib/expiry.
The second commit is completely unrelated but fixes up what appears to be a botched auto-merge that resulted in duplicate imports of the logging package in agent/xds/server.go. Regardless I wanted to make the linter happy so its fixed too.