HCD: Implement nomad job status display #16
Conversation
|
Hey @jawahars16, that is amazing! Thx for this PR. I just glanced over it and it looked good.. I'll give it a proper review until the end of the day. |
There was a problem hiding this comment.
Hey @jawahars16, thank you so much for your PR 👏 This is a huge help. The PR looks good in general but I added a handful of comments. Let me know if these make sense to you and if you have any questions just let me know.
- Used API instead of shell command to fetch Job Status - Added tablewriter to format the output - Added job status data into a separate model
|
Hi @hcjulz I have fixed the feedbacks and updated the PR. Can you please take a look and let me know? |
There was a problem hiding this comment.
Hey @jawahars16, this looks really amazing now!
I added a few really minor comments that I think could be addressed and then we can ship 🚢 this! Looking really forward to merging it.
- Reused header constants - Using existing GetJob function - Added job ID to title
|
Updated the PR. @hcjulz 🤞🏽 |
|
Great Job @jawahars16 👏 I just merged your PR 🚀 |
|
Thanks @hcjulz 😄 Can you also please remove the label |
What is this about?
This PR adds the nomad job status view to Damon, which can be displayed when hitting
ion a selected job in the jobs view. The status gives the exact same response as the commandnomad job status <job-id>Preview