Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds accessibility statement to app footer #109

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Conversation

MelSumner
Copy link
Contributor

📌 Summary

Adds an accessibility statement to the application footer.

📸 Screenshots

CleanShot 2022-03-22 at 14 17 14

👀 How to review

👉 Review by files changed

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2022

⚠️ No Changeset found

Latest commit: 827b7e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/D9AWSTe3KbHTten8Mmyh7oKmaT1J
✅ Preview: https://hds-flight-website-git-melsumner-a11y-statement-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/Dvkfg3XWekKVHyaTtZoE8ozAcu7Y
✅ Preview: https://hds-components-git-melsumner-a11y-statement-hashicorp.vercel.app

@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 22, 2022 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 22, 2022 19:22 Inactive
@MelSumner MelSumner requested review from didoo and amyrlam and removed request for Dhaulagiri March 22, 2022 19:25
packages/components/tests/dummy/app/styles/app.scss Outdated Show resolved Hide resolved
packages/components/tests/dummy/app/styles/app.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-blocking suggestions. Since there are some issues on Cristiano's review, waiting til they're addressed before leaving a review

Another non-blocking suggestion: Would be cool to have a link for "WCAG 2.1 AA standards", or briefly explain what it is, as some folks might not know what it is

@vercel vercel bot temporarily deployed to Preview – hds-components March 23, 2022 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 23, 2022 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 23, 2022 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 23, 2022 13:06 Inactive
@MelSumner MelSumner merged commit 8148213 into main Mar 23, 2022
@MelSumner MelSumner deleted the melsumner/a11y-statement branch March 23, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants