-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for list positioning #170
added support for list positioning #170
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). hds-flight-website – ./🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/2YibA1x3WiojyNd3PYy2teqcZQqy hds-components – ./🔍 Inspect: https://vercel.com/hashicorp/hds-components/7ZUTkojZbQe1zUXo9aLVRL8ZG8AF |
packages/components/tests/dummy/app/templates/components/dropdown.hbs
Outdated
Show resolved
Hide resolved
…to melsumner/refactor-list-item
* refactored heading and help text
…to melsumner/dropdown-list-pos # Conflicts: # packages/components/tests/dummy/app/templates/components/dropdown.hbs
…to melsumner/dropdown-list-pos # Conflicts: # packages/components/tests/dummy/app/templates/components/dropdown.hbs
📌 Summary
If merged, this PR adds support for
@listPosition
so that users can indicate how they want the list positioned. Default position is to the right; if@listPosition="left"
is added when invoking the component, the list will be positioned on the left.I used a string value instead of a boolean because it gives us future flexibility (i.e., adding
top
(left/right) andbottom
(left/right) variations).Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.