Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for list positioning #170

Merged
merged 11 commits into from
Apr 4, 2022

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Apr 4, 2022

📌 Summary

If merged, this PR adds support for @listPosition so that users can indicate how they want the list positioned. Default position is to the right; if @listPosition="left" is added when invoking the component, the list will be positioned on the left.

I used a string value instead of a boolean because it gives us future flexibility (i.e., adding top (left/right) and bottom (left/right) variations).

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.


@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

⚠️ No Changeset found

Latest commit: a2cd83e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/2YibA1x3WiojyNd3PYy2teqcZQqy
✅ Preview: https://hds-flight-website-git-melsumner-dropdown-list-pos-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/7ZUTkojZbQe1zUXo9aLVRL8ZG8AF
✅ Preview: https://hds-components-git-melsumner-dropdown-list-pos-hashicorp.vercel.app

@vercel vercel bot temporarily deployed to Preview – hds-components April 4, 2022 14:38 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 4, 2022 14:38 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components April 4, 2022 16:00 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 4, 2022 16:00 Inactive
Base automatically changed from melsumner/refactor-list-item to melsumner/dropdown-component April 4, 2022 21:13
…to melsumner/dropdown-list-pos

# Conflicts:
#	packages/components/tests/dummy/app/templates/components/dropdown.hbs
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 4, 2022 21:18 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components April 4, 2022 21:18 Inactive
@MelSumner MelSumner merged commit 13bbd9c into melsumner/dropdown-component Apr 4, 2022
@MelSumner MelSumner deleted the melsumner/dropdown-list-pos branch April 4, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants