Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion - add @isStatic, @type, and @size #2156

Merged
merged 33 commits into from
Jul 8, 2024
Merged

Accordion - add @isStatic, @type, and @size #2156

merged 33 commits into from
Jul 8, 2024

Commits on Jul 8, 2024

  1. Add @isStatic argument

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c87ca65 View commit details
    Browse the repository at this point in the history

  2. Add @type argument

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    de05139 View commit details
    Browse the repository at this point in the history

  3. Restructured accordion showcase and added @type

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fe53560 View commit details
    Browse the repository at this point in the history

  4. Adjust focus state for 'flush' variant

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    7e39603 View commit details
    Browse the repository at this point in the history

  5. Adjust hover and active states for 'flush' variant

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fab0407 View commit details
    Browse the repository at this point in the history

  6. Adjustments for nested flush accordions

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8229ec9 View commit details
    Browse the repository at this point in the history

  7. Add flush example with generic content in toggle

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    46cc2fe View commit details
    Browse the repository at this point in the history

  8. Add @size argument

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0cbd52f View commit details
    Browse the repository at this point in the history

  9. Adjustments to Accordion::Item::Button

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5cb80bd View commit details
    Browse the repository at this point in the history

  10. Fix type for card when is static

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ffb1e6a View commit details
    Browse the repository at this point in the history

  11. Add changelog entry

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2063bda View commit details
    Browse the repository at this point in the history

  12. Component fixes based on feedback

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d78a1d5 View commit details
    Browse the repository at this point in the history

  13. Reorder showcase sections

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    33ac156 View commit details
    Browse the repository at this point in the history

  14. Style adjustments based on feedback 

    Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
    @alex-ju @didoo
    alex-ju and didoo committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    58b2bba View commit details
    Browse the repository at this point in the history

  15. Reorder items in sizeMap

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f450235 View commit details
    Browse the repository at this point in the history

  16. Add exception to automated a11y testing

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    18e3007 View commit details
    Browse the repository at this point in the history

  17. Add mixed nested examples

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    606c18c View commit details
    Browse the repository at this point in the history

  18. Replace Sass variables with CSS variables

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    aa53139 View commit details
    Browse the repository at this point in the history

  19. Refactor CSS to make use of scoped variables

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3694ee5 View commit details
    Browse the repository at this point in the history

  20. Refactor isStatic to render a hidden button

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5691670 View commit details
    Browse the repository at this point in the history

  21. Fix Accordion::Item::Button size after refactor

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    72f6632 View commit details
    Browse the repository at this point in the history

  22. Apply suggestions from code review 

    Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
    @alex-ju @didoo
    alex-ju and didoo committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    295f556 View commit details
    Browse the repository at this point in the history

  23. Remove Sass variables 

    Were only being used in a single instance
    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ea92207 View commit details
    Browse the repository at this point in the history

  24. Rename CSS variable

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d1a4d05 View commit details
    Browse the repository at this point in the history

  25. Refactor showcase

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ce9f0cf View commit details
    Browse the repository at this point in the history

  26. Move sizeMap up one level as TEXT_SIZE_MAP

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    dd4542a View commit details
    Browse the repository at this point in the history

  27. Add tests for @size and @type at parent and item levels

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    53b29cd View commit details
    Browse the repository at this point in the history

  28. Add more bespoke padding/spacing on various sizes

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1742c6f View commit details
    Browse the repository at this point in the history

  29. Adjust content padding and border for nested flush accordions

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0a89f8c View commit details
    Browse the repository at this point in the history

  30. Use inset focus ring for flush accordion items

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    dacf074 View commit details
    Browse the repository at this point in the history

  31. Fix Accordion::Item::Button showcase

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f792dad View commit details
    Browse the repository at this point in the history

  32. Adjustments after #2181

    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4217df5 View commit details
    Browse the repository at this point in the history

  33. Remove top border for accordion item flush 

    Also moved from `box-shadow` (used for an inset border) to `border`
    @alex-ju
    alex-ju committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2304da4 View commit details
    Browse the repository at this point in the history