Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enterprise Nav: AppHeader component (HDS-3373) #2161

Merged
merged 86 commits into from
Jul 29, 2024
Merged

Enterprise Nav: AppHeader component (HDS-3373) #2161

merged 86 commits into from
Jul 29, 2024

Commits on Jul 24, 2024

  1. HDS-3372 Add preliminary example of SideNav with changes for pairing … 

    …with AppHeader, Add styling to remove excess spacing from empty header and footer
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9c58319 View commit details
    Browse the repository at this point in the history

  2. HDS-3373 Create AppHeader component, add related examples to Showcase 

    # Conflicts:
#	showcase/app/templates/layouts/app-frame/index.hbs
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    87a22bc View commit details
    Browse the repository at this point in the history

  3. HDS-3373 Update AppHeader styles to add border and dropshadow from ne… 

    …wer design mocks, change buttons in Showcase to use Hds::Button icon only variant
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f19830c View commit details
    Browse the repository at this point in the history

  4. HDS-3373 Add suishies to remove white space, Refactor styling to use … 

    …:empty selector to remove excess padding in empty elements
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8e4c30a View commit details
    Browse the repository at this point in the history

  5. HDS-3373 Make aria-labels unique to pass accessibility tests

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5120433 View commit details
    Browse the repository at this point in the history

  6. HDS-3373 Update logo size, update examples to add Terraform example a… 

    …nd shift items around to match mocks
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c53b58a View commit details
    Browse the repository at this point in the history

  7. HDS-3373 Fix signature name, adjust AppHeader height to follow newer … 

    …mocks
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    44ddd3a View commit details
    Browse the repository at this point in the history

  8. HDS-3373 Add components to registry

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    42d42a7 View commit details
    Browse the repository at this point in the history

  9. HDS-3373 Refactor named block slots to simplify

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e0136d2 View commit details
    Browse the repository at this point in the history

  10. HDS-3373 Add tests for AppHeader content and HomeLink child component

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2f31f3f View commit details
    Browse the repository at this point in the history

  11. HDS-3373 Fix icon type, add HomeLink examples to Showcase

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e268188 View commit details
    Browse the repository at this point in the history

  12. HDS-3373 Overhaul css for interactive component dark color palette mi… 

    …xin, apply styles to child components via inheritance, add examples of interactive child components to Showcase
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    25d956d View commit details
    Browse the repository at this point in the history

  13. HDS-3373 Change box-shadow to use black to fix unwanted glow effect

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fc41e8f View commit details
    Browse the repository at this point in the history

  14. HDS-3373 Create shared interactive dark theme mixin and update AppHea… 

    …der and SideNav to use for interactive components
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    959c3a4 View commit details
    Browse the repository at this point in the history

  15. HDS-3373 Change gap of 'slots' to inherit from app-header parent

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1eeebda View commit details
    Browse the repository at this point in the history

  16. HDS-3373 Add narrower width for collapsed SideNav w/o header content

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    02a7ad9 View commit details
    Browse the repository at this point in the history

  17. HDS-3373 Add conditionals to dark theme mixin for sidenav

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1dfb46c View commit details
    Browse the repository at this point in the history

  18. HDS-3373 Add preliminary functionality for responsive menu, remove Ap… 

    …pHeader box-shadowm fix button focus styles
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0780d5e View commit details
    Browse the repository at this point in the history

  19. HDS-3373 Refactor globalItems into 2 slots for before and after, yiel… 

    …d after content in 2 places for inclusion in responsive menu
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4e596ae View commit details
    Browse the repository at this point in the history

  20. HDS-3373 Adjust spacing, padding, and min-height to match latest mocks

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    82f2004 View commit details
    Browse the repository at this point in the history

  21. HDS-3373 Force nested dropdowns to display to left in responsive view

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d74a92f View commit details
    Browse the repository at this point in the history

  22. HDS-3373 Add examples with long organization names to Showcase

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ed39bf5 View commit details
    Browse the repository at this point in the history

  23. HDS-3373 Remove future phase content from long content examples

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9eac4db View commit details
    Browse the repository at this point in the history

  24. HDS-3373 Fix failing tests

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4f97227 View commit details
    Browse the repository at this point in the history

  25. HDS-3373 Refactor how responsive styles are applied and clean up CSS

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9827c94 View commit details
    Browse the repository at this point in the history

  26. HDS-3373 Tweak min-height and padding to match Figma

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5b13a32 View commit details
    Browse the repository at this point in the history

  27. HDS-3373 Use border radius from button mixin for AppHeader nested int… 

    …eractives, make app-header layout fixed with full screen height responsive menu but override for showcase examples
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    985e5c1 View commit details
    Browse the repository at this point in the history

  28. HDS-3373 Fix 'disappearing' Button & Dropdown border, apply dark them… 

    …e to nested SideNav interactive components following AppHeader pattern
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a98be53 View commit details
    Browse the repository at this point in the history

  29. HDS-3373 Fix responsive behavior

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bac5b9d View commit details
    Browse the repository at this point in the history

  30. HDS-3373 Fix linting errors, simplify selectors for applying dark int… 

    …eractive them to SideNav components
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f648ae0 View commit details
    Browse the repository at this point in the history

  31. HDS-3373 re-organize dark theme states, update color tokens following… 

    … mocks
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    54bb19e View commit details
    Browse the repository at this point in the history

  32. HDS-3373 Add commas for linter

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e6ed7df View commit details
    Browse the repository at this point in the history

  33. HDS-3373 Fix linting errors

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b73ddd9 View commit details
    Browse the repository at this point in the history

  34. HDS-3373 Fix linting errors

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cadbf85 View commit details
    Browse the repository at this point in the history

  35. HDS-3373 Add hasHeader arg to SideNav to adjust padding and toggle bu… 

    …tton position when app-header is present, add test
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    39b43cf View commit details
    Browse the repository at this point in the history

  36. HDS-3373 Fix linting for files

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    437fe4e View commit details
    Browse the repository at this point in the history

  37. HDS-3373 Fixed layout issues with fixed app-header overlapping main c… 

    …ontent, cleaned up css tokens, fixed issue with dark theming for interactive components using old class name
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cfb998c View commit details
    Browse the repository at this point in the history

  38. HDS-3373 Adjust SideNav toggleButton position when :header is empty

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f2bd62b View commit details
    Browse the repository at this point in the history

  39. HDS-3373 Update OrgSwitcher edge case example with longest possible c… 

    …ontent
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d541c2f View commit details
    Browse the repository at this point in the history

  40. HDS-3373 Add height variable in style to replaced incorrect hard-code… 

    …d value, update comments for clarity
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1e0f701 View commit details
    Browse the repository at this point in the history

  41. HDS-3373 Add back hds-side-nav-header as a selector for adding dark t… 

    …heme interactive styles to fix Showcase
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2f01832 View commit details
    Browse the repository at this point in the history

  42. HDS-3373 Remove/replace JSDoc comments

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6c990f4 View commit details
    Browse the repository at this point in the history

  43. HDS-3373 Add return type for ariaLabel getter

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    aea1f38 View commit details
    Browse the repository at this point in the history

  44. HDS-3373 Add prefix to menu content id, add return types to getters a… 

    …nd methods
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    54aef4c View commit details
    Browse the repository at this point in the history

  45. Apply suggestions from code review 

    Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
    @KristinLBradley @didoo
    KristinLBradley and didoo committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2bc0b5d View commit details
    Browse the repository at this point in the history

  46. HDS-3373 Fix incorrrect height value, move class name to template

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c91c189 View commit details
    Browse the repository at this point in the history

  47. HDS-3373 Rename appHeader global named blocks

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    761831e View commit details
    Browse the repository at this point in the history

  48. HDS-3373 removed unused event from onClickToggle

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1a1fca6 View commit details
    Browse the repository at this point in the history

  49. HDS-3373 Fix issues with focus styles for interactive elements, clean… 

    … up css
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5c8d494 View commit details
    Browse the repository at this point in the history

  50. HDS-3373 Clean up token naming

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e66b7ff View commit details
    Browse the repository at this point in the history

  51. HDS-3373 Refactor to use JS to control hide/show of items vs css

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9f0b0e4 View commit details
    Browse the repository at this point in the history

  52. HDS-3373 Add additional tests for responsiveness, menu behavior, and … 

    …a11y features
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    dae9735 View commit details
    Browse the repository at this point in the history

  53. HDS-3373 Rename globalItems and utilityItems to globalActions and uti… 

    …lityActions
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    50d0fcb View commit details
    Browse the repository at this point in the history

  54. HDS-3375 Refactor AppHeader to eliminate duplicate globalActions to i… 

    …nstead use CSS for responsive views, set frame header container to position sticky instead of making AppHeader position absolute
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    736de5e View commit details
    Browse the repository at this point in the history

  55. HDS-3375 Fix issue with hovered border of disabled actions

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d470a48 View commit details
    Browse the repository at this point in the history

  56. HDS-3373 Clean up old eslint disable comment, add missing type

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4b229c1 View commit details
    Browse the repository at this point in the history

  57. Replace type any in blocks with empty array

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    429977e View commit details
    Browse the repository at this point in the history

  58. HDS-3373 Set width value for headerless sidenav directly instad of cr… 

    …eating a new custom property
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4f27720 View commit details
    Browse the repository at this point in the history

  59. Add design tokens JSON for AppHeader

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4fbc775 View commit details
    Browse the repository at this point in the history

  60. HDS-3373 Regenerate design tokens in output

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    711d9bc View commit details
    Browse the repository at this point in the history

  61. HDS-3373 Update css to remove token definitions on root which were re… 

    …placed by JSON tokens
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1c8115a View commit details
    Browse the repository at this point in the history

  62. HDS-3373 rename SideNav hasHeader param to withAppHeader, add additio… 

    …nal temp dropdown position override styles, add misc content to Showcase example
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a334b1e View commit details
    Browse the repository at this point in the history

  63. HDS-3373 Undo changes to appFrame test

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9d01a4e View commit details
    Browse the repository at this point in the history

  64. HDS-3373 Update old classname, replace :has selector with logic in te… 

    …mplate to add class
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    179c51a View commit details
    Browse the repository at this point in the history

  65. HDS-3373 Move menu button so it renders before the menu it controls m… 

    …atching visual order
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9b709bd View commit details
    Browse the repository at this point in the history

  66. HDS-3373 Add frameless test pages for AppHeader and SideNav

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    11ab2e2 View commit details
    Browse the repository at this point in the history

  67. HDS-3373 Add basic main content to frmaeless examples

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    eb6d92c View commit details
    Browse the repository at this point in the history

  68. HDS-3373 Hide content in minimized SideNav for demos

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5d6cfca View commit details
    Browse the repository at this point in the history

  69. HDS-3373 Add extra long content to frameless test page to test breakp… 

    …oint
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    08d8583 View commit details
    Browse the repository at this point in the history

  70. HDS-3373 Expose breakpoint variable so consumers can choose to override

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    277c843 View commit details
    Browse the repository at this point in the history

  71. HDS-3373 Replace operator

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3c1f808 View commit details
    Browse the repository at this point in the history

  72. HDS-3373 Refactor menu content so wrapper with id stays in DOM, refac… 

    …tor related layout styles and tests
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f6d87f8 View commit details
    Browse the repository at this point in the history

  73. HDS-3373 Add Showcase example and test for custom breakpoint options,… 

    … code clean up
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    eff53ca View commit details
    Browse the repository at this point in the history

  74. HDS-3373 Add css custom property to replace fixed values for home-lin… 

    …k width and height
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e925063 View commit details
    Browse the repository at this point in the history

  75. HDS-3373 Refactor sizing & layout styles for home-link and svg logo

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    59b594a View commit details
    Browse the repository at this point in the history

  76. HDS-3373 Update design tokens for AppHeader

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7827d24 View commit details
    Browse the repository at this point in the history

  77. HDS-3373 Regenerate design tokens in output

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    40257b0 View commit details
    Browse the repository at this point in the history

  78. HDS-3373 Delete temporary custom properties replaced by tokens

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    32d9c3f View commit details
    Browse the repository at this point in the history

  79. HDS-3373 Fix mistaken value for logo size in token

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0383fc4 View commit details
    Browse the repository at this point in the history

  80. HDS-3373 Regenerate design tokens in output

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4cc09c4 View commit details
    Browse the repository at this point in the history

  81. HDS-3373 Add changsets for components and tokens

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4d2783b View commit details
    Browse the repository at this point in the history

  82. HDS-3373 Prevent interaction with AppHeader when SideNav is expanded

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    12c9773 View commit details
    Browse the repository at this point in the history

  83. Update mean-tools-repair.md

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    97c20e3 View commit details
    Browse the repository at this point in the history

  84. Update tough-tigers-dress.md

    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5d6c72b View commit details
    Browse the repository at this point in the history

  85. HDS-3373 CSS fixes: scope style preventing interaction to mobile view… 

    …, remove temp styles forcing Dropdown position, improve Showcase mobile menu appearance
    @KristinLBradley
    KristinLBradley committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    57cd62d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Enterprise Nav: AppHeader web docs (#2239) 

    Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Co-authored-by: Cristiano Rastelli <public@didoo.net>
    @KristinLBradley @jorytindall @didoo
    4 people authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4c7c87c View commit details
    Browse the repository at this point in the history