Dropdown::Toggle::Icon: Fix inconsistencies (HDS-3416)
#2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
2 tasks
jorytindall
reviewed
Jun 24, 2024
There was a problem hiding this comment.
I added a couple of other comments on Friday, but I failed to submit the review 😞 .
I've also added a bit of a matrix here for what is changing. Let me know if this makes sense, but essentially I think it breaks down like this:
Dropdown::ToggleIconwherehasChevron={{true}}and has aniconsize="small"icon size should be12pxsize="medium"icon size should16px
I think everything else should be unchanged.
…ons without chevrons
jorytindall
approved these changes
Jun 24, 2024
KristinLBradley
changed the title
Dropdown: Fix inconsistencies (HDS-3416)Dropdown::Toggle::Icon: Fix inconsistencies (HDS-3416)
didoo
approved these changes
Jun 25, 2024
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
KristinLBradley
commented
Jun 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR fixes inconsistencies in color and toggle icon sizing between the
Dropdown::Toggle::Iconas compared to theButtoncomponent.Showcase: https://hds-showcase-git-hds-3416-fix-dropdown-inconsi-809ea9-hashicorp.vercel.app/components/dropdown#icon
📸 Screenshots
BEFORE:
AFTER:
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.