Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated heading structure in BadgeCount docs #2184

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

heatherlarsen
Copy link
Contributor

@heatherlarsen heatherlarsen commented Jun 24, 2024

📌 Summary

If merged, this PR fixes an incorrect heading structure in the BadgeCount documentation.

preview: https://hds-website-git-hl-badgecount-docs-fix-hashicorp.vercel.app/components/badge-count

🛠️ Detailed description

"Type", "Color", and "Size" headings were changed from an H3 to an H2.

📸 Screenshots

Before:
Screenshot 2024-06-24 at 3 10 19 PM

After:
Screenshot 2024-06-24 at 3 10 24 PM

🔗 External links

Jira ticket: HDS-3440


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 24, 2024 10:15pm
hds-website ✅ Ready (Inspect) Visit Preview Jun 24, 2024 10:15pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jun 24, 2024
@heatherlarsen heatherlarsen requested review from a team June 24, 2024 22:17
@heatherlarsen heatherlarsen changed the title Updating heading structure Updating heading structure in BadgeCount docs Jun 24, 2024
@heatherlarsen heatherlarsen changed the title Updating heading structure in BadgeCount docs Updated heading structure in BadgeCount docs Jun 24, 2024
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@heatherlarsen heatherlarsen merged commit fe67367 into main Jun 25, 2024
12 checks passed
@heatherlarsen heatherlarsen deleted the hl-badgecount-docs-fix branch June 25, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants