Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase - Added use cases for display variants to the icon page #2186

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Jun 25, 2024

📌 Summary

To facilitate the work that @zamoore is doing around the conversion of the EmberFlightIcon to Hds::Icon I've added a few more use cases to the "Icon" showcase page, to cover a few variants of how its display/layout work.


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested review from zamoore and a team June 25, 2024 14:13
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 25, 2024 2:16pm
hds-website ✅ Ready (Inspect) Visit Preview Jun 25, 2024 2:16pm

Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@didoo didoo merged commit 8a8f314 into main Jun 26, 2024
15 checks passed
@didoo didoo deleted the showcase-improve-icon-coverage branch June 26, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants