Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hds::Icon Documentation Updates #2221

Merged
merged 47 commits into from
Jul 30, 2024
Merged

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Jul 8, 2024

📌 Summary

This PR is part of #2207

If merged, this PR will:

  • Add documentation for the Hds::Icon component in the website app - see preview
  • Add new links between the icon library and component docs - see preview
  • Update the "For engineers" content about icons - see preview

🔗 External links

Feature branch PR: 2207
Jira ticket: HDS-3519


Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 30, 2024 6:19pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 30, 2024 6:19pm

@zamoore zamoore changed the title Hds icon documentation Hds::Icon Documentation Updates Jul 8, 2024
@zamoore zamoore changed the base branch from FEATURE-BRANCH-HdsIcon to HdsIcon-icon_component July 8, 2024 20:21
@zamoore zamoore marked this pull request as ready for review July 10, 2024 18:17
@zamoore zamoore requested a review from a team July 10, 2024 18:18
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

website/docs/components/icon/index.md Show resolved Hide resolved
website/docs/components/icon/index.md Show resolved Hide resolved
website/docs/components/icon/partials/code/how-to-use.md Outdated Show resolved Hide resolved
website/docs/components/icon/partials/code/how-to-use.md Outdated Show resolved Hide resolved
majedelass and others added 22 commits July 30, 2024 14:13
…dated format and provided a little more information.
Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Co-authored-by: Zack Moore <zack.moore@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Majed <156002572+majedelass@users.noreply.github.com>
Base automatically changed from HdsIcon-icon_component to FEATURE-BRANCH-HdsIcon July 30, 2024 19:42
@zamoore zamoore merged commit 4a52df8 into FEATURE-BRANCH-HdsIcon Jul 30, 2024
16 checks passed
@zamoore zamoore deleted the HdsIcon-documentation branch July 30, 2024 19:50
zamoore added a commit that referenced this pull request Jul 31, 2024
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Co-authored-by: Majed Elass <majed.elass@hashicorp.com>
Co-authored-by: Majed <156002572+majedelass@users.noreply.github.com>
Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
Co-authored-by: Cristiano Rastelli <public@didoo.net>
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
didoo added a commit that referenced this pull request Aug 1, 2024
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Co-authored-by: Majed Elass <majed.elass@hashicorp.com>
Co-authored-by: Majed <156002572+majedelass@users.noreply.github.com>
Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
Co-authored-by: Cristiano Rastelli <public@didoo.net>
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants