-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hds::Icon
Documentation Updates
#2221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashibot-hds
added
packages/components
packages/ember-flight-icons
docs-website
Content updates to the documentation website
showcase
labels
Jul 8, 2024
zamoore
changed the base branch from
FEATURE-BRANCH-HdsIcon
to
HdsIcon-icon_component
July 8, 2024 20:21
zamoore
force-pushed
the
HdsIcon-documentation
branch
from
July 10, 2024 17:44
c0c296d
to
cee5a84
Compare
didoo
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
website/docs/components/icon/partials/accessibility/accessibility.md
Outdated
Show resolved
Hide resolved
…ovided overview text. Added a resources tab.
…dated format and provided a little more information.
Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
Co-authored-by: Alex <alex-ju@users.noreply.github.com> Co-authored-by: Zack Moore <zack.moore@hashicorp.com> Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Majed <156002572+majedelass@users.noreply.github.com>
zamoore
force-pushed
the
HdsIcon-documentation
branch
from
July 30, 2024 18:14
8f79082
to
6e2d9c8
Compare
Base automatically changed from
HdsIcon-icon_component
to
FEATURE-BRANCH-HdsIcon
July 30, 2024 19:42
zamoore
added a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com> Co-authored-by: Majed Elass <majed.elass@hashicorp.com> Co-authored-by: Majed <156002572+majedelass@users.noreply.github.com> Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com> Co-authored-by: Cristiano Rastelli <public@didoo.net> Co-authored-by: Alex <alex-ju@users.noreply.github.com> Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
didoo
added a commit
that referenced
this pull request
Aug 1, 2024
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com> Co-authored-by: Majed Elass <majed.elass@hashicorp.com> Co-authored-by: Majed <156002572+majedelass@users.noreply.github.com> Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com> Co-authored-by: Cristiano Rastelli <public@didoo.net> Co-authored-by: Alex <alex-ju@users.noreply.github.com> Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR is part of #2207
If merged, this PR will:
Hds::Icon
component in the website app - see preview🔗 External links
Feature branch PR: 2207
Jira ticket: HDS-3519