-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hds::Icon
Codemod
#2224
Hds::Icon
Codemod
#2224
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
Would you be able to add some tests too? See the contextual-components
codemod, as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment. Apart from that, it's OK for me 👍
PS: I like how you split the tests in different files, with meaningful names. Probably something we want to replicate for future codemods, it's neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments. Not blockers, but better to address them.
3be4cb0
to
ef5ad64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
📌 Summary
This PR is part of #2207
The proposed functionality for this codemod is to:
FlightIcon
toHds::Icon
@isInlineBlock={{false}}
as this is now the default behavior@isInlineBlock={{true}}
(if any) with@isInline={{true}}
Links
Issue #3532