Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hds::Icon Codemod #2224

Merged
merged 13 commits into from
Jul 30, 2024
Merged

Hds::Icon Codemod #2224

merged 13 commits into from
Jul 30, 2024

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Jul 9, 2024

📌 Summary

This PR is part of #2207

The proposed functionality for this codemod is to:

  1. Update component invocation from FlightIcon to Hds::Icon
  2. Remove instances of @isInlineBlock={{false}} as this is now the default behavior
  3. Replace instances of @isInlineBlock={{true}} (if any) with @isInline={{true}}

Links

Issue #3532

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 30, 2024 7:16pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 30, 2024 7:16pm

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

Would you be able to add some tests too? See the contextual-components codemod, as an example.

.changeset/tricky-eagles-protect.md Outdated Show resolved Hide resolved
packages/codemods/transforms/v4/icon/index.js Outdated Show resolved Hide resolved
packages/codemods/transforms/v4/icon/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Apart from that, it's OK for me 👍

PS: I like how you split the tests in different files, with meaningful names. Probably something we want to replicate for future codemods, it's neat.

packages/codemods/transforms/v4/icon/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Not blockers, but better to address them.

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zamoore zamoore merged commit a3c5ce8 into FEATURE-BRANCH-HdsIcon Jul 30, 2024
12 checks passed
@zamoore zamoore deleted the HdsIcon-codemod branch July 30, 2024 19:51
zamoore added a commit that referenced this pull request Jul 31, 2024
didoo pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants