defect (WithTable): Fix WithVersion(...) to work with WithTable(...) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambrt
force-pushed
the
jimlambrt-with-table
branch
from
9ad4a75
to
e098ed0
Compare
louisruch
reviewed
Dec 13, 2021
| wantArgs []interface{} | ||
| wantErr bool | ||
| }{ | ||
| { |
There was a problem hiding this comment.
Might be nice to have a test that exercises the with-version-on-conflict without the WithTable to confirm the tableName = mDb.Statement.Schema.Table path is working.
There was a problem hiding this comment.
is that the next test?
Fixes issue #9: WithTable(...) not working correctly for when used in addition to WithVersion(...
jimlambrt
force-pushed
the
jimlambrt-with-table
branch
from
77a5979
to
f282df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #9: WithTable(...) not working correctly for when used in
addition to WithVersion(...