Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove direct dependency on golang.org/x/net #240

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 3, 2023

Reference: https://pkg.go.dev/golang.org/x/net@v0.0.0-20190311183353-d8887717615a/context
Reference: #186

Previously, the module was only using golang.org/x/net/context import. That package was deprecated with Go 1.7 when its functionality migrated into the standard library context package. This Go module already announces Go 1.17 minimum since version 1.4.4 and the context types are not exposed as part of any exported API.

Reference: https://pkg.go.dev/golang.org/x/net@v0.0.0-20190311183353-d8887717615a/context
Reference: #186

Previously, the module was only using `golang.org/x/net/context` import. That package was deprecated with Go 1.7 when its functionality migrated into the standard library `context` package. This Go module already announces Go 1.17 minimum since version 1.4.4 and the `context` types are not exposed as part of any exported API.
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bflad bflad merged commit d78f3fc into main Mar 6, 2023
@bflad bflad deleted the bflad/remove-x-net-direct-dependency branch March 6, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants