Preserve log keys order #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@fairclothjm would you take a look at this one at you availability? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to preserve the log keys' order provided by the plugin.
Currently, the host unmarshalls the logs emitted by the plugin into a map and uses its keys to create an output that is passed to the host logger. However, the order of the map keys is non-deterministic, resulting in a non-deterministic keys order passed to the host logger.
To address this issue, this pull request extracts the keys in an ordered manner and adds unit tests to ensure that the produced output preserves the order.
This PR solves #266