-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Admin Settings API #185
Conversation
Awesome, thanks @omarismail! 🤝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good!
I skimmed a lot and had enough feedback to stop and revisit in more detail a second time around; the biggest bit is to double check all these APIs to see if they're all covered in the structs; I think a lot of the documentation around these APIs is woefully out of date 😩
…shicorp/go-tfe into omarismail/admin-settings-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two quick nits and this is ready to merge!
Description
This PR adds all the Admin Settings API.
It implements the API for each Settings:
Testing plan
Output from tests
External links