List workspace variable sets #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uk1288
reviewed
Oct 17, 2022
Uk1288
reviewed
Oct 17, 2022
sebasslash
force-pushed
the
list-workspace-variable-sets
branch
3 times, most recently
from
00db685
to
ff6cb30
Compare
Uk1288
reviewed
Oct 17, 2022
|
|
||
| t.Run("when Workspace ID is an invalid ID", func(t *testing.T) { | ||
| vsl, err := client.VariableSets.ListForWorkspace(ctx, badIdentifier, nil) | ||
| assert.Nil(t, vsl) |
There was a problem hiding this comment.
test assertion ErrInvalidWorkspaceID instead of ErrInvalidOrg
sebasslash
force-pushed
the
list-workspace-variable-sets
branch
from
ff6cb30
to
5d4da4e
Compare
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build off of #520 and #551, maintaining the original interface but adding missing test helper to apply a variable set to a workspace (otherwise test fails).
This also fixes the assertion that a given variable set is contained within the list fetched from workspace.
assert.Contains()is a tricky call because it performs deep equality. A resource may or may not have relationships defined depending on the endpoint you're calling, in this case: