-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workspace auto destroy duration field #902
Conversation
@@ -2747,7 +2748,7 @@ func TestWorkspacesAutoDestroy(t *testing.T) { | |||
}) | |||
t.Cleanup(wCleanup) | |||
|
|||
require.Equal(t, wTest.AutoDestroyAt, autoDestroyAt) | |||
require.Equal(t, autoDestroyAt, wTest.AutoDestroyAt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swapped the order on these since require wants require.Equal(t, <expected>, <actual>)
347ce82
to
1db4eea
Compare
1db4eea
to
8531617
Compare
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Adds an
auto_destroy_activity_duration
field to Workspaces (see API docs). Makes use ofjsonapi.NullableAttr
because this is an optional string field, but we will want to be able to send an explicit null to unset.Testing plan
envchain go-tfe go test -run "TestWorkspacesAutoDestroy.*" -v ./...
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.