More flexible parameter handling in NewRequest and friends #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the tfe.go changes look good. Just need to appease the almighty lint deity! |
- additionalQueryParams should be used for all request methods - reqBody should be encoded as url query parameters for GET requests
brandonc
force-pushed
the
brandonc/query_params_on_non_get_requests
branch
from
1e85b0d
to
417505b
Compare
glennsarti
approved these changes
Aug 13, 2024
|
|
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glennsarti noted that go-tfe demonstrated some odd query parameter encoding behavior depending on http method, and that url.QueryEncode was used throughout the code when we actually should have used the slightly more narrow url.PathEncode.