Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not call onEvict when adding an existing item #153

Closed
wants to merge 1 commit into from
Closed

fix: do not call onEvict when adding an existing item #153

wants to merge 1 commit into from

Conversation

mgaffney
Copy link
Member

Calling Add, ContainsOrAdd, or PeekOrAdd with a key that is already in the cache should not trigger an eviction.

Resolves #141, closes #152.

@mgaffney
fix: do not call onEvict when adding an existing item
68d23fc 
Calling Add, ContainsOrAdd, or PeekOrAdd with a key that is already in
the cache should not trigger an eviction.

Resolves #141, closes #152.
@mgaffney mgaffney requested a review from jefferai August 22, 2023 20:25
@mgaffney
Copy link
Member Author

Need to make additional updates. Will open a new PR when ready.

@mgaffney mgaffney closed this Aug 23, 2023
@mgaffney mgaffney deleted the mgaffney/issue-141 branch August 23, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai Awaiting requested review from jefferai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onEvicted is called with incorrect item when a previous Add overwrites an existing item
1 participant
@mgaffney