Enable dynamic label completions #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
dynamic_label_completions
branch
4 times, most recently
from
a8de26d
to
b8f6175
Compare
radeksimko
force-pushed
the
dynamic_label_completions
branch
from
aa7eb7d
to
d30d6c6
Compare
dbanck
force-pushed
the
dynamic_label_completions
branch
from
21ff108
to
8ba2676
Compare
This adds support for completing the label for a given dynamic block and for completing the content for dependent blocks.
radeksimko
force-pushed
the
dynamic_label_completions
branch
from
e8eda19
to
2f3ca8f
Compare
Arguably the function now does more than merging, so it should probably be called something like "resolveBlockBodySchema", but I'm leaving that for another PR/iteration.
radeksimko
force-pushed
the
dynamic_label_completions
branch
from
2f3ca8f
to
a9a84fe
Compare
radeksimko
approved these changes
Nov 24, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the next stage for dynamic block completion. Based on the blocks of a dependent body, we can now complete the label for
dynamicblocks based on the available block names and the block-related attributes in thecontentblock. It works for nested blocks, too.UX in Terraform
Completion
Hover
In nested blocks
Semantic tokens