Use local ref. targets for count.index
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-count-index-refs
branch
from
096954b
to
5076ad2
Compare
dbanck
approved these changes
Nov 22, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #159
This PR changes collection of reference targets, such that we now collect
count.indexas a target to thecountattribute. This in turn enables go-to-definition and go-to-references betweencountandcount.index.Additionally, it updates completion, hover and semantic tokens, to make use of this reference target and just treat it like any other valid reference.
Lastly I updated the description of the
countattribute to reflect what it does and also add the note about conflict we already have in thefor_eachdescription.UX in Terraform
Completion (w/ updated description)
Hover (w/ updated description)
Go-to-* (new)