-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoder: Add support for Reference
as Constraint
#185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
January 17, 2023 15:50
6e478db
to
1f7d84f
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
3 times, most recently
from
January 30, 2023 09:29
3f78a98
to
705f3b6
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
January 31, 2023 10:11
705f3b6
to
c3d83dc
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
February 16, 2023 15:10
c3d83dc
to
f58dcd5
Compare
radeksimko
changed the title
decoder/schema: Add support for
decoder: Add support for Mar 7, 2023
Reference
as Constraint
Reference
as Constraint
15 tasks
radeksimko
force-pushed
the
f-expr-cons-reference
branch
8 times, most recently
from
March 22, 2023 11:26
59128a1
to
23202d1
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
March 22, 2023 15:46
23202d1
to
7409f49
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
March 22, 2023 20:42
7409f49
to
871393e
Compare
This was referenced Mar 23, 2023
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
March 23, 2023 10:48
fc1f37e
to
29857ca
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
March 23, 2023 11:20
29857ca
to
512e774
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
March 23, 2023 12:46
512e774
to
87468f3
Compare
radeksimko
force-pushed
the
f-expr-cons-reference
branch
from
March 23, 2023 18:01
87468f3
to
c301189
Compare
jpogran
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-ls#496
There is quite a lot of logic related to reference collection, which I am not touching in this PR. That will be addressed more broadly as part of #239 I did however go through all the related legacy tests and made sure they pass (when using
schema.Reference
) in combination with this PR.The updated tests are in c0a2da2
UX