decoder: Refactor newExpression() & plumb PathContext
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
changed the title
newExpression() & plumb PathContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily to make it easier to "hand-over" completion/hover/etc. between different expression types (which do not /need to/ have access to all of
PathDecoder) and reduce diff conflicts between upcoming PRs where each involves different expression type.It is expected that all complex types (list, set, tuple, map, object) may contain either
Reference(hence needReferenceTargets) orAnyExpression(hence need futureFunctionsMapand possiblyReferenceTargetstoo).I have briefly considered creating a separate type, e.g.
ExpressionContextor pass these things viacontext.Context, or use the staticnewExpression()in all places where(*PathDecoder) newExpression()is now used, but concluded that it would all be premature optimization at this point.