Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Display Tuple hover data on invalid element #254

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Apr 13, 2023

As discovered in #251

I am not sure if this is the right/best UX, but it is the behaviour we had before, as per the test in #251

UX Before

2023-04-13 15 13 57

UX After

2023-04-13 14 25 04

@radeksimko radeksimko added the enhancement New feature or request label Apr 13, 2023
@radeksimko radeksimko self-assigned this Apr 13, 2023
@radeksimko radeksimko changed the title decoder: Display Tuple hover data on invalid element decoder: Display Tuple hover data on invalid element Apr 13, 2023
@radeksimko radeksimko marked this pull request as ready for review April 13, 2023 14:14
@radeksimko radeksimko requested a review from a team as a code owner April 13, 2023 14:14
@dbanck dbanck merged commit 34c0b60 into main Apr 18, 2023
@dbanck dbanck deleted the f-tuple-unknown-elem-hover branch April 18, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants