decoder: Implement InferType for complex expressions
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
radeksimko
added
enhancement
|
Closing in favour of #259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #251
Related to #247
One alternative (possibly simpler) solution here would be falling back to
ConstraintType()of the corresponding constraint (List, Set, Tuple, Map, Object). I do see some benefits in the ability to infer types though in the long run.UX Impact
There currently aren't any constraints in the Terraform schema involving "partially known" types as explained above, so there's no expected UX impact on Terraform LS users.
This was only discovered because some existing tests in #251 use the mentioned constraints.